fix: update some build permissions when the source repo is private#1351
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1351.dev.renku.ch |
Coverage Report for CI Build 28375065596Coverage at 86.203% (no base build to compare)Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
sgaist
requested changes
Jun 29, 2026
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
sgaist
approved these changes
Jun 29, 2026
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1347.
Updated permissions when the source repository is private:
db.pymethodGET /builds/<build_id>get_build()GET /environments/<environment_id>/buildsget_environment_builds()POST /environments/<environment_id>/buildsstart_build()PATCH /builds/<build_id>update_build()GET /builds/<build_id>/logsget_build_logs()_refresh_build()Note: in the case of
POST /environments/<environment_id>/builds, this avoids starting a build which would fail at thesourcestep./deploy extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user,dataService.imageBuilders.privateRepositoryBuilds.enabled=true,dataService.imageBuilders.privateRepositoryBuilds.outputPrivateImagePrefix=harbor.dev.renku.ch/renku-ci-private-images-build-private-project/,dataService.imageBuilders.privateRepositoryBuilds.pushPrivateSecretName=renku-build-private-docker-secret,dataService.imageBuilders.privateRepositoryBuilds.pullPrivateSecretName=renku-build-private-docker-secret